Ticket #485 (closed bug: fixed)

Opened 21 months ago

Last modified 16 months ago

No way existing to stop a music

Reported by: nobody Owned by: theli
Priority: minor Milestone: 0.6
Component: Other Version:
Keywords: Cc:

Description (last modified by theli) (diff)

Using soft like xbindkeys to link a soft like Listen with keyboard multimedia key, I remarked that there is no way to stop a music... You can play one using the command: listen -p you can pause using: listen --play-pause previous with: listen --previous and next with: listen --next However there no command to stop the music like it could be: listen -s or listen --stop Why? It is pretty annoying. Thanks and otherwise you soft is good ;) and the last beta do not freeze anymore on my computer ;)

Attachments

add_stop_button_and_commandline_option.patch (6.4 kB) - added by zdogde 17 months ago.
patch that adds stop buttons

Change History

Changed 21 months ago by paol

Logged In: YES user_id=1146319

I would like to extend the submiter's report to include the GUI, which also doesn't have a Stop button. Why have Stop, why is Pause not enough? 1) Because it's expected in music/video playing devices, both hardware and software. 2) Because Pause doesn't release the sound card, in systems that don't have software mixers no other program will be able to open the sound device (happens whenever you have to use a legacy app that uses OSS instead of ALSA, for example)

Regarding point 1: people have been trained for decades to expect these buttons, in this order: back, play, pause, stop, forward (with play and pause sometimes in the same button). I realise Gnome has taken to removing the Stop button lately. That's their mistake, no need for Listen to copy it.

Regarding point 2: that could also be fixed by having Pause release the audio device...

Changed 20 months ago by pochu

Logged In: YES user_id=1450347 Originator: NO

2) Because Pause doesn't release the sound card

Yes, that is very important, and this should be fixed with a high priority. Maybe with a Stop feature, maybe with Pause doing it. Maybe the two!

Changed 18 months ago by theli

  • description modified (diff)
  • milestone set to 0.5

Changed 18 months ago by theli

  • milestone changed from 0.5 to 0.6

Changed 17 months ago by zdogde

  • status changed from assigned to closed
  • resolution set to fixed

I created a patch which: - adds a stop button right to the play/pause button - adds a stop menuitem to the tray - adds a commandline option "--stop"

the patch is attached

Changed 17 months ago by zdogde

patch that adds stop buttons

Changed 17 months ago by pochu

  • status changed from closed to reopened
  • resolution deleted

Please, close it once it has been applied to the source tree

Changed 17 months ago by zdogde

ok i will do for the future :) sorry

Changed 17 months ago by pochu

No problem. It's just to not forget to apply the patch. Otherwise, we can skip it. And thanks to you for making the patch! :D

Keep the good work guys. You rock! Pochu

Changed 16 months ago by theli

  • status changed from reopened to closed
  • resolution set to fixed

(In [747]) patch from zdogde, fixes #619, #617, #611, #612, #610, #485

Note: See TracTickets for help on using tickets.